Skip to content

Infinispan client update #691

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
miuponn wants to merge 16 commits into
base: vNext
Choose a base branch
from
Open

Infinispan client update #691

miuponn wants to merge 16 commits into from

Conversation

@miuponn
Copy link

@miuponn miuponn commented May 29, 2025

Fixes #673

Previously hardcoded client version in pom.xml generation is replaced with configurable version at build time or via env in Dockerfile.

Adds support for the following environment variables and build args:

  • INFINISPAN_CLIENT_VERSION: Set the base version of the client
  • USE_LATEST_COMPATIBLE: If true, script uses latest compatible version using versions:use-latest-releases

@CLAassistant
Copy link

CLAassistant commented May 29, 2025 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@leochr
Copy link
Member

leochr commented Jun 9, 2025

@miuponn Thank you for the PR. Please sign the CLA (see above comment for further information). Also, it's good to sign the commits.

@leochr
Copy link
Member

leochr commented Jun 9, 2025

@idlewis As you had raised this issue, please review the PR as well. Thank you

@leochr leochr requested a review from idlewis June 9, 2025 19:16
idlewis
idlewis reviewed Jun 10, 2025
View reviewed changes
idlewis
idlewis reviewed Jun 10, 2025
View reviewed changes
idlewis
idlewis reviewed Jun 10, 2025
View reviewed changes
idlewis
idlewis previously approved these changes Jun 17, 2025
View reviewed changes
Copy link
Member

@idlewis idlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me.
Does this also need to go in 25.0.0.5 (as well as latest)?
Do we also need update our docs?

@leochr
Copy link
Member

leochr commented Jun 17, 2025

Thank you for the review, Iain. 25.0.0.6 will be released today (and 25.0.0.5 will be removed from support). Let's target this for 25.0.0.7, in which case, making the changes only to latest would be sufficient.

@leochr
Copy link
Member

leochr commented Jun 17, 2025

Please hold off merging as the vNext changes for 25.0.0.6 haven't been merged yet into the main branch. I'll merge when ready.

@dougbreaux dougbreaux mentioned this pull request Jul 28, 2025
Open
leochr
leochr reviewed Aug 25, 2025
View reviewed changes
Copy link
Member

@leochr leochr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miuponn As we discussed, added a couple of comments. Thank you

@miuponn miuponn force-pushed the infinispan-client-update branch from 68b11b6 to 9bb086a Compare January 28, 2026 19:05
@miuponn miuponn force-pushed the infinispan-client-update branch from 9bb086a to d8c843f Compare January 28, 2026 19:09
@miuponn miuponn closed this Jan 28, 2026
@miuponn miuponn force-pushed the infinispan-client-update branch from d8c843f to 158f7aa Compare January 28, 2026 19:13
@miuponn miuponn reopened this Jan 28, 2026
@miuponn
Copy link
Author

miuponn commented Jan 28, 2026

Consolidated with review comments and issues #704 and #669 and added updated changes to infinispan-client-setup.sh

  • Added additional INFINISPAN_DEFAULT_VERSION variable to be referenced instead of putting it in the parameter of INFINISPAN_CLIENT_VERSION for clarity
  • Set Infinispan 15.2.6.Final as default client version. 15.2.x is currently under full support until May 2026, supports Jakarta native namespaces, stable and should work with most modern Open Liberty builds
  • Infinispan versions 11+ requires reactive streams dependencies for caching in Open Liberty, so the lines that trimmed reactive stream jars for pre-11.0 versions are now a conditional that can be configured if necessary (should not be needed for most part)
  • Updated section for removing transaction API jars after installation with new jakarta namespace jakarta.transaction-api*.jar for modern builds

Changes from #744 in helper config files for Infinispan are needed in order for the configurability update here in infinispan-client-setup.sh to work.

@miuponn
Copy link
Author

miuponn commented Jan 28, 2026 •
edited
Loading

Configurability has some known issues for specific client versions and environment compatibility boundaries, will update session caching documentation to accompany script changes

@miuponn
Update README.md
aeee38b 
Initial changes to Session caching section of readme to accompany configurable infinispan script updates
@miuponn miuponn mentioned this pull request Jan 29, 2026
Open
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@leochr leochr leochr left review comments

@idlewis idlewis idlewis left review comments

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@miuponn @CLAassistant @leochr @idlewis @wraschke